Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3651 dev/core#1337 Fix failure to show last column data in output, spaces in names #23771

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

dev/core#3651 dev/core#1337 Fix failure to show last column data in output, spaces in names

Fixes an RC regression whereby the outputting of import results was not putting data in the last column

In addition, as this required testing the sql datasource I used a query that was failing per https://lab.civicrm.org/dev/core/-/issues/1337 and included the fix for that in here. The query I used was

SELECT id, first_name as 'First Name', last_name as 'LAST NAME' from civicrm_contact;

(Note that there are other pre-existing issues with the sql that I obsevered in that some sql operators are htmlised - ignoring)

Before

Per https://lab.civicrm.org/dev/core/-/issues/3651

After

It's baa-aack

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jun 11, 2022

(Standard links)

@civibot civibot bot added the 5.51 label Jun 11, 2022
@demeritcowboy
Copy link
Contributor

It works for 3651. I didn't test the sql data source part.

@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Jun 12, 2022
@eileenmcnaughton
Copy link
Contributor Author

I'm merging per the merge-ready as I did test the sql part & also I want to get more people to QA & don't want them to hit the already-fixed issue in here

@eileenmcnaughton eileenmcnaughton merged commit 3ee1c05 into civicrm:5.51 Jun 14, 2022
@eileenmcnaughton eileenmcnaughton deleted the cont_update branch June 14, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.51 merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants