Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix for failing test in master
Before
After
fixed
Technical Details
There is a failing test in master because of a sequence of events - two PRs were merged at once resulting in a real conflict - so we rush merged the PR that addressed that - but a test fail got in - the reason was the NOT
!
got missed in the last patch - when converting$onDuplicate != CRM_Import_Parser::DUPLICATE_UPDATE
to
$this-isUpdateExisting()
-However, in the fix I also moved it to the validate function as anything that can be determined without db look ups belongs in validate
Comments