Fix test to validate forms & remove some unused code

[eileenmcnaughton]

Overview

Fix test to validate forms & remove some unused code

This moves test functionality to a generic test trait & adds form validation. Unused code removed

screenshots from my r-run to check no issues from removed code

We hates it my preciouses

It correctly failed

Now mum is failed

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

OK looks good.

[eileenmcnaughton]

I removed a couple more things - it tests the same except it has a new enotice which will be fixed by the move to queue runner

[eileenmcnaughton]

test this please