Participant import fix - broken uniqueName fields, mapping saving, ev… #23733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_part
branch
2 times, most recently
from
038104a to
011ab68
Compare
…ent_id This switches to using 'normal' field names for all participant fields.
eileenmcnaughton
force-pushed
the
import_part
branch
from
011ab68 to
b4167b7
Compare
eileenmcnaughton
commented
Jun 8, 2022
| @@ -88,11 +94,13 @@ protected function importCSV(string $csv, array $fieldMappings, array $submitted | |||
| $form = $this->getFormObject('CRM_Event_Import_Form_MapField', $submittedValues); | |||
| $form->setUserJobID($this->userJobID); | |||
| $form->buildForm(); | |||
| $this->assertTrue($form->validate()); | |||
There was a problem hiding this comment.
@demeritcowboy I managed to add these after two of the buildForm calls - the first one fails on the file upload rule which seems tricky
There was a problem hiding this comment.
Cool. Would need to look closer - there's that low-level php function move_uploaded_file or something that you used to have to use in the previous century to access the file for security reasons, so maybe there's an extra hurdle for those.
There was a problem hiding this comment.
yep - but running validate will def help find stuff
|
Looks good. Ok to merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This addresses reviewer feedback by @aydun on the Participant import cleanup currently merged.
#23703 (comment)
It addresses
This also switches away from using unique names in the participant import - which simplifies the code a little
Contact matching
This is a pre-existing confusion that we would ideally come up with a good answer for it - I think this PR gets us to the pre-existing behaviour & we should pick up over here https://lab.civicrm.org/dev/core/-/issues/3180
Note to self - re-test :"update mapping" works - UPDATE - yep UI test worked to update a field in a mapping