Towards consistency for displaying test entities. Stop hiding test entities on some dashboards

[mattwire]

Overview

There is no consistency as to whether test entities are shown on (eg. contact tabs). Some do and some don't. This makes test entities rather less useful because you can't see the results.
Eg. in the case of an event signup you don't see the participant record in the contact events tab if it is a test. But you do see the test contributions (but not in the user dashboard..).

This PR changes those that were hidden based on the "force" parameter so that test entities are not filtered out and are displayed. This provides consistency and standardisation.

In most cases the UI will already show ( test ) or make it clear in some way that the entity is a test.

Before

Very inconsistent display of test entities.

After

Consistent display of test entities.

Technical Details

This has always annoyed me, using the "_force" param (which is meant for triggering an immediate search) to decide whether to show test entities in some situations. And makes for some awkward conversations when training people on CiviCRM - eg. "You'll see that it's created a test contribution but you won't see the event registration because that's a test and Civi hides those. So why can I see the contribution? Because civi doesn't hide those? But it does in the dashboard? Yes, but only for contriubutions..."

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

[CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentEmptyContact](https://test.civicrm.org/job/CiviCRM-Core-PR/49573/testReport/junit/(root)/CRM_Contact_Page_View_UserDashBoardTest/testDashboardContentEmptyContact/)
[CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentContributionsWithInvoicingEnabled](https://test.civicrm.org/job/CiviCRM-Core-PR/49573/testReport/junit/(root)/CRM_Contact_Page_View_UserDashBoardTest/testDashboardContentContributionsWithInvoicingEnabled/)
[CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentContributions](https://test.civicrm.org/job/CiviCRM-Core-PR/49573/testReport/junit/(root)/CRM_Contact_Page_View_UserDashBoardTest/testDashboardContentContributions/)
[CRM_Contact_Page_View_UserDashBoardTest.testDashboardPartialPayments](https://test.civicrm.org/job/CiviCRM-Core-PR/49573/testReport/junit/(root)/CRM_Contact_Page_View_UserDashBoardTest/testDashboardPartialPayments/)

[demeritcowboy]

Maybe it's all the forest-fire smoke I've been breathing but when this PR first went up I didn't think too much about it since it seemed like more of a developer thing. But I'm now a medium-hard +1 on it. (Read that as you will.)

jenkins retest this please

My thinking is if real users don't use test mode anyway (which anecdotally is true), then this doesn't really change anything on most installs.

[colemanw]

I'll add my +1 as well. Make mine over-easy 🍳

[demeritcowboy]

I think you've coined a new phrase. An "over-easy opinion".

jenkins retest this please (date rollover issue, probably delayed trying to process what the comments are talking about).

[mattwire]

@demeritcowboy thanks for picking this up - looks like tests are all passing now :-)

[mattwire]

Thanks @demeritcowboy