Enable QueueRunner for all imports #23712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Jun 7, 2022
| /** | ||
| * Clean up the import table we used. | ||
| */ | ||
| public function postProcess() { |
There was a problem hiding this comment.
this function used to do cleanup -now it doesn't. It was never about blocking higher up functions
eileenmcnaughton
commented
Jun 7, 2022
| @@ -45,8 +45,6 @@ public function buildQuickForm() { | |||
| unset($sel1['membership_id']); | |||
| } | |||
|
|
|||
| $sel2[''] = NULL; | |||
There was a problem hiding this comment.
this is copy & paste - it never did anything but does cause some weirdness if you go forwards from the Preview screen & then back again
eileenmcnaughton
force-pushed
the
import_queue
branch
3 times, most recently
from
2ea6ae6 to
6488aaf
Compare
eileenmcnaughton
changed the title
|
I just rebased this over #23719 - which should be merged before this or with it - they can be r-run tested together |
eileenmcnaughton
force-pushed
the
import_queue
branch
2 times, most recently
from
ea36f37 to
24717e3
Compare
eileenmcnaughton
force-pushed
the
import_queue
branch
from
24717e3 to
79091ae
Compare
|
Tests are happy. Let's get this into the RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enable QueueRunner for membership import
Before
Non contact imports still using the old ajax method
After
All imports use the queue runner
Technical Details
@totten I think it's good if Contact isn't the only import we are r-running when we test queues.
Note that the same summary screen works for all
Comments
Just noting that we might need to re-instate a version of the error