Fix import activity & add tests

[eileenmcnaughton]

Extends #23703 to do all the same things for activity import

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[aydun]

On first screen of Activity Import, the help icon produces a pop-up with no information.

Warnings on second page:

    Warning: Undefined array key "savedMappingName" in include() (line 8 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Undefined array key 2 in include() (line 77 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Trying to access array offset on value of type null in include() (line 77 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Undefined array key 2 in include() (line 77 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Trying to access array offset on value of type null in include() (line 77 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Undefined array key 2 in include() (line 77 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Trying to access array offset on value of type null in include() (line 77 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Undefined array key "savedMappingName" in include() (line 83 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Undefined array key "mappingDetailsError" in include() (line 107 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%2E/2E3/2E3CBBFD%%MapTable.tpl.php).
    Warning: Undefined array key "highlightedRelFields" in include() (line 14 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/default/files/civicrm/templates_c/en_US/%%31/319/31965542%%highLightImport.tpl.php).

[aydun]

After hitting Continue on step 2 (Match fields):

Error: Call to undefined method CRM_Activity_Import_Parser_Activity::setFieldMetadata() in CRM_Import_Parser->getMappedFieldLabel() (line 1773 of /home/jenkins/bknix-dfl/build/core-23703-3lxzt/web/sites/all/modules/civicrm/CRM/Import/Parser.php).

[aydun]

When using a saved mapping, I get extra empty dropdowns:

[eileenmcnaughton]

I just rebased this over the fixes on participant - and got through the whole flow

[colemanw]

Let's get this merged so we can test them all together

[eileenmcnaughton]

@aydun can you re-test once merged & we will address any issues - it's actively broken without this