Contact import - extract common code, make tags & groups queue-friendly #23680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
contact_map
branch
from
f36f72e to
86faf01
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
contact_map
branch
from
86faf01 to
dcbe28c
Compare
The new way is - create the tags & groups at the form layer & only the ids go to the parser - which adds them This patch should be a nullop in terms of the efficiency of these
eileenmcnaughton
force-pushed
the
contact_map
branch
from
dcbe28c to
578e4db
Compare
eileenmcnaughton
force-pushed
the
contact_map
branch
from
4817bd9 to
8d0967f
Compare
|
🤠 |
|
I spoke to soon on that last part. Line 307 isn't squashing a previously set status. But DUPLICATE is only set when SKIPPING. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extract common part of MapTable.tpl
Before
Most of the file is generic & could be shared with other imports - but there is just one bit of js plonked in the middle holding us back
After
The js is still in the contact specific file - but the rest is in CRM/Import/MapTableCommon.tpl
Screenshots from my after r-run
Technical Details
Any issues would be very obvious on r-run - which I did
There is already
MapTableinCRM/Import/- it is awful -{section}anyone? This is the path to migrate offComments
Putting up a separate PR to use this in Contribution flow - which has a bug to fix - but that is a separate r-run flow