[NFC] Failing test for api chain using sequential #23675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
you are amazing @demeritcowboy |
seamuslee001
reviewed
Jun 2, 2022
| 'api.Address.getoptions' => [ | ||
| 'field' => 'state_province_id', | ||
| 'country_id' => '$value.id', | ||
| 'sequential' => 1, |
There was a problem hiding this comment.
@demeritcowboy you could have left sequential off here just to demonstrate that sequential gets added in by default but 6/1 0.5/12
There was a problem hiding this comment.
Good point. I'll just add a third case.
seamuslee001
reviewed
Jun 2, 2022
| ]); | ||
| $this->assertSame(['key' => 1000, 'value' => 'Alabama'], $result['api.Address.getoptions']['values'][0]); | ||
| $this->assertSame(['key' => 1001, 'value' => 'Alaska'], $result['api.Address.getoptions']['values'][1]); | ||
| $this->assertSame(['key' => 1049, 'value' => 'Wyoming'], $result['api.Address.getoptions']['values'][59]); |
There was a problem hiding this comment.
why are there 59 Keys here?
There was a problem hiding this comment.
Because there are some territories like American Samoa that aren't technically states.
There was a problem hiding this comment.
But they shoud be - the revolution starts here. Equal rights for all civicrm_state_province rows
There was a problem hiding this comment.
It's come up for sure in some places like Puerto Rico. It's even come up in Canada.
demeritcowboy
force-pushed
the
test-sequential
branch
from
0376b9f to
ea5a2b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Failing test for #23672
It will pass now though since 23672 is merged.
This is the same type of call uscounties makes.
@seamuslee001 @totten @eileenmcnaughton