Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - add address proximity (map radius) search #23597

Merged
merged 3 commits into from
May 31, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 26, 2022

Overview

Allows searching for addresses within a given distance of a location.

image

Notes

Update: now works with most mapping providers (originally hardcoded only for Google Maps) via #23646

@civibot
Copy link

civibot bot commented May 26, 2022

(Standard links)

@civibot civibot bot added the master label May 26, 2022
@colemanw colemanw force-pushed the searchKitProximity branch from bc06bf2 to 671dac8 Compare May 26, 2022 14:09
@eileenmcnaughton
Copy link
Contributor

image

@colemanw colemanw force-pushed the searchKitProximity branch from 671dac8 to d2a29eb Compare May 26, 2022 16:28
@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label May 30, 2022
@eileenmcnaughton
Copy link
Contributor

ok let's merge it - it would be good to test in the rc (I'm fighting geocoders right now) and it shouldn;'t affect existing code

@eileenmcnaughton eileenmcnaughton merged commit 941983b into civicrm:master May 31, 2022
@eileenmcnaughton eileenmcnaughton deleted the searchKitProximity branch May 31, 2022 04:19
@demeritcowboy
Copy link
Contributor

Ok just I had marked it merge-ready to give the mystery sponsor time to see if it worked for their use case.

@eileenmcnaughton
Copy link
Contributor

Well it can get further fixes if need be

@awestuk
Copy link
Contributor

awestuk commented May 31, 2022

That's us! We will test asap - we need to run an upgrade first, so we're just waiting for the security drop. It looks like just what we're after though.

@colemanw
Copy link
Member Author

colemanw commented May 31, 2022

One thing I'll note about this PR is that it only works with Google. (which, afaik is the only geocoder that actually works with CiviCRM at the moment, but still noteworthy)
Update That's no longer the case thanks to #23646

@awestuk
Copy link
Contributor

awestuk commented Jun 1, 2022

Upgraded and tested and working well! Does exactly what we wanted. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-test master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants