Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import] [ref] Move function to parent for use by siblings #23592

Merged
merged 2 commits into from
May 27, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 26, 2022

Overview

[Import] [ref] Move function to parent for use by siblings

Before

Hogged by one child

After

Just like my spotify account anyone in the family can use it ... if Jack isn't using it ... so never

Technical Details

I switched to using getParser rather than

   $parser = new CRM_Contact_Import_Parser_Contact();
    $parser->setUserJobID($this->getUserJobID());

That function is already on the class the function is being moved from (and is added to the others in #23590 )

  • the others have a call to init but I didn't add that here as I didn't want to make any changes that would require a full r-run in this PR

Comments

@civibot
Copy link

civibot bot commented May 26, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

Looks like this e-notices without #23591

@seamuslee001 seamuslee001 merged commit b994930 into civicrm:master May 27, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_parent branch May 27, 2022 02:59
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants