APIv4 - Exclude disabled custom fields

[colemanw]

Overview

Ensures that disabled custom fields do not show up in API results or in Search Kit.

Before

Disabled custom fields available in SearchKit.

After

Disabled fields hidden.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@colemanw do we need to do something about the multi record custom fields as well?

[colemanw]

Good catch. I've updated the PR and added a test for that as well.

[guyiac]

I tested the first demo just now and it worked fine. Waiting for the second demo to finish completing checks to test that.

[guyiac]

Tested the second demo and it worked fine.

1. Activated Search Kit extension.
2. Created search with Most Important Issue custom field.
3. Disabled Most Important Issue custom field.
4. Verified that field was gone from first search and didn't show up in a new one.
5. Created multiple value custom field set.
6. Created two new custom fields in set.
7. Verified both fields were available for search views.
8. Disabled one of the fields.
9. Verified that the field was no longer available for search views.

[demeritcowboy]

For reference there's a longstanding discussion about whether they should or shouldn't show: #14240 (comment) and also https://lab.civicrm.org/dev/core/-/issues/19. I suppose this PR matches where it is most places.

[colemanw]

Ok I went back and re-read that issue, and then double-checked the APIv3 behavior, and this PR matches it (disabled custom fields are not shown in APIv3 getFields). Based on that, I think this PR is ok to merge, but we could consider further refinements in the future.