Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show honor roll only if it's enabled for the PCP page #23567

Merged
merged 1 commit into from
May 31, 2022
Merged

show honor roll only if it's enabled for the PCP page #23567

merged 1 commit into from
May 31, 2022

Conversation

kurund
Copy link
Contributor

@kurund kurund commented May 24, 2022

No description provided.

@civibot
Copy link

civibot bot commented May 24, 2022

(Standard links)

@civibot civibot bot added the master label May 24, 2022
@kurund kurund force-pushed the honor-roll-fixes branch from 1f98c61 to 0df07a1 Compare May 24, 2022 10:59
@eileenmcnaughton
Copy link
Contributor

This is just the addition on an if - makes sense to me but I don't use this functionality so adding merge-ready + pinging @KarinG @MegaphoneJon

image

@eileenmcnaughton eileenmcnaughton added the merge ready PR will be merged after a few days if there are no objections label May 24, 2022
@kurund kurund force-pushed the honor-roll-fixes branch from 0df07a1 to 5743040 Compare May 25, 2022 12:49
@kurund
Copy link
Contributor Author

kurund commented May 25, 2022

@eileenmcnaughton

I had missed adding similar condition for email receipt and is added in latest push.

@eileenmcnaughton eileenmcnaughton merged commit 2c7e217 into civicrm:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurund @eileenmcnaughton