Another always-true-if #23559
Merged
Another always-true-if #23559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_yay
branch
from
e10c895 to
ffb2a41
Compare
monishdeb
reviewed
May 26, 2022
| @@ -550,7 +546,7 @@ public function import($onDuplicate, &$values) { | |||
| CRM_Utils_Hook::import('Contact', 'process', $this, $hookParams); | |||
| } | |||
|
|
|||
| if ($relationship) { | |||
| if (1) { | |||
There was a problem hiding this comment.
@eileenmcnaughton that means the else part is unreachable right?
There was a problem hiding this comment.
@monishdeb yes - I hadn't picked that up - but if you merge this I will remove the IF altogether & the else & do whitespace in a follow up
|
Simple cleanup, doesn't impact the import process, did a quick r-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Another always-true-if
Before
We can see that both the
ifand theelseset relationship toTRUE- the only exception is if it returns - in which case the if isn't reacheAfter
Clarified - whitespace change pending
Technical Details
I have a couple of places like this now waiting for potentially conflicting PRs to be merged before cleaning up the whitespace
Comments