Duplicate function - divide & conquer #23542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_location2
branch
from
2a6c48e to
b248c09
Compare
stesi561
reviewed
May 22, 2022
| * Legacy format profile contact parameters. | ||
| * | ||
| * This is a formerly shared function - most of the stuff in it probably does | ||
| * nothing but copied here to star unravelling that... |
There was a problem hiding this comment.
Hmm - I might take that on board for a follow up as I have a few patches locally that build on this
|
Have diffed against the original code - this looks fine. There is a change from using self-> to this-> however the calling is now being done not in a static context so this makes sense. Additionally as the original context was static all the changes to calling methods other than this in the original Class are fine. Haven't had a chance to r-run. |
|
thanks @stesi561 - there is good test cover here - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
formatProfileContactfunction is a LOT - it is called from the import & causes some notices - however, as a shared function called by lots of legacy code it isn't something we want to mess with.We have used the divide and conquer function pretty successfully elsewhere - copy the function back to the class & then with it only being called from one place strip it back to the bit that ACTUALLY DOES something
Before
Abject fear
After
More duplicate code :-( but a path forwards to add import testing & fix on phone imports
Technical Details
Comments