Extend import option handling to prefix, suffix, language, communication_style #23535
Conversation
|
(Standard links)
|
| @@ -775,16 +775,6 @@ protected static function contactTrash($contact): bool { | |||
| * | |||
| */ | |||
| public static function resolveDefaults(&$defaults, $reverse = FALSE) { | |||
| // Hack for birth_date. | |||
There was a problem hiding this comment.
This function is only called from the import parser. We already added extensive cover for birth_date handling so this can go along with the options
| @@ -482,25 +485,6 @@ public function import($onDuplicate, &$values) { | |||
| //now we create new contact in update/fill mode also. | |||
| $contactID = NULL; | |||
| if ($createNewContact || ($this->_updateWithId)) { | |||
| // @todo - there are multiple places where formatting is done that need consolidation. | |||
There was a problem hiding this comment.
This was added in conjuction with CRM_Contact_Import_Parser_ContactTest::testPreferredLanguageImport as a generic way to handle preferred_language labels. The same is already being achieved in the getTransformedFieldValue so this is now obsolete
eileenmcnaughton
force-pushed
the
import_prefix
branch
2 times, most recently
from
d8e2829 to
092ac7e
Compare
…ion_style This extends a pattern thoroughly tested for gender to other single-option-value fields & removes duplicate handling. Test cover in `CRM_Contact_Import_Parser_ContactTest::testPrefixLabel` `CRM_Contact_Import_Parser_ContactTest::testPreferredLanguageImport`
eileenmcnaughton
force-pushed
the
import_prefix
branch
from
092ac7e to
c0010ab
Compare
|
@colemanw this is passing post rebase now - are you able to merge? I haven't added additional tests because there was existing cover of the specific affected fields and the generic handling |
|
Did r-run on local and works fine, rightful change to cleanup the cruft code. Updated unit test passes too. |
|
Yay - thanks @monishdeb - now I have to rebase some others :-) |
Overview
Extend import option handling to prefix, suffix, language, communication_style
This extends a pattern thoroughly tested for gender to
other single-option-value fields & removes duplicate handling.
Test cover in
CRM_Contact_Import_Parser_ContactTest::testPrefixLabelCRM_Contact_Import_Parser_ContactTest::testPreferredLanguageImportBefore
Complicated handling
After
Leverages metadata based handling thoroughly tested for gender
Technical Details
Comments