Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import] Check subtype validity in validate rather than wait for 'imort' #23526

Merged
merged 1 commit into from
May 20, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[Import] Check subtype validity in validate rather than wait for 'import', test

Before

Validate routine does not check for contact subtype validity - but it will (often) fail on import

After

getParams does the mapping to ensure we have a name & then this can be checked during validation

Technical Details

Test cover added

Comments

@civibot
Copy link

civibot bot commented May 20, 2022

(Standard links)

@colemanw
Copy link
Member

Ok, I see this refactor is covered by tests.

@colemanw colemanw merged commit 69d6d95 into civicrm:master May 20, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_sub branch May 20, 2022 21:44
@eileenmcnaughton
Copy link
Contributor Author

yay - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants