Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Remove unreachable code
Before
The contents of this 'if' are unreachable - however important they pretend to be
As we can see from #23505 -
$params['id']
is always an integer if we get this far & hence per #23506$matchedIDs
is never empty if we get this far - so theelse
will never be accessedAfter
poof
Technical Details
There is actually test cover here in the
Parser_ContactTest
classThe actual updates happen in the loop a little lower down....
Comments