Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref Extract import validation #23498

Merged
merged 2 commits into from
May 20, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 19, 2022

Overview

Ref Extract import validation

Basic extraction

Before

looong

After

Extracted

Technical Details

One of the goals here is to break away from all this code being shared between the contact & other parser classes - there is stuff shared thatis working way too hard & we actually can validate custom data along with core data but there are too many classes involved, for now

Comments

Test cover in, eg. CRM_Contribute_Import_Parser_ContributionTest::testCustomSerializedCheckBox

@civibot
Copy link

civibot bot commented May 19, 2022

(Standard links)

@civibot civibot bot added the master label May 19, 2022
@eileenmcnaughton
Copy link
Contributor Author

Test Result (1 failure / +1)CRM_Contact_Import_Parser_ContactTest.testCustomFieldValidation

Test Result (1 failure / +1)
CRM_Contact_Import_Parser_ContactTest.testCustomFieldValidation

@colemanw
Copy link
Member

+1 for adding tests

@colemanw colemanw merged commit ec59969 into civicrm:master May 20, 2022
@colemanw colemanw deleted the import_cust_extract branch May 20, 2022 01:34
@eileenmcnaughton
Copy link
Contributor Author

thanks @colemanw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants