[REF] [Import] Stop calling Parser in MapField mode (contact import) #23470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] [Import] Stop calling Parser in MapField mode
Before
The
DataSource
form callsCRM_Contact_Import_Parser_Contact::run()
- however, this no longer does anythingAfter
poof
Technical Details
The point of calling
run
here was to load the csv and calculate information like the number of rows and the headers which was then passed to the next form using$form->set()
and retrieved using$form->get()
on the following form. Nothing isset
anymore & only a couple of values are still potentially subject to 'get' callsComments
@monishdeb this is a further clean up following the csv stuff you merged