Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] Stop calling Parser in MapField mode (contact import) #23470

Merged
merged 1 commit into from
May 18, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] [Import] Stop calling Parser in MapField mode

Before

The DataSource form calls CRM_Contact_Import_Parser_Contact::run() - however, this no longer does anything

After

poof

Technical Details

The point of calling run here was to load the csv and calculate information like the number of rows and the headers which was then passed to the next form using $form->set() and retrieved using $form->get() on the following form. Nothing is set anymore & only a couple of values are still potentially subject to 'get' calls

image

image

Comments

@monishdeb this is a further clean up following the csv stuff you merged

@civibot
Copy link

civibot bot commented May 16, 2022

(Standard links)

@civibot civibot bot added the master label May 16, 2022
@eileenmcnaughton
Copy link
Contributor Author

@monishdeb this removes code made obsolete by other PRs you merged so make make sense to you

@monishdeb
Copy link
Member

Right, did a quick check at the patch and did r-run on my local just to be sure, and looks good to me. Merging now.

@monishdeb monishdeb merged commit 4dc354e into civicrm:master May 18, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_dataform branch May 18, 2022 02:59
@eileenmcnaughton
Copy link
Contributor Author

@monishdeb yay - that nasty code is melting away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants