dev/core#2300 Can not use Custom Fields defined on a contact_sub_type in dedupe…

[darrick]

Overview

Year old issue is here: https://lab.civicrm.org/dev/core/-/issues/2300

I added Finder tests for the Custom Field types because I wasn't sure if every field type was supported. I.e. date, int, float, etc. Doing that found another bug in that if a user created a rule programmatically with sub Type fields. dedupeWithParams would not find a match because the passed in params were getting filtered incorrectly.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

code seems fine to me the only question is on the hook change to me @eileenmcnaughton thoughts?

[eileenmcnaughton]

I think the hook change is OK - those hooks are awful just jammed in there all over the place - but I don't think this change is material to how it operates

[eileenmcnaughton]

I've also looked into your import test enough now to see that this is also impacting on the test you wrote for that too.

Thanks for all the extra tests!