Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Allow functions in the GROUP BY clause #23434

Merged
merged 1 commit into from
May 12, 2022

Conversation

colemanw
Copy link
Member

Overview

See dev/core#2485

Before

Cannot use functions in the GROUP BY clause.

After

image

Comments

There's still more to do to make this really useful, like allowing that expression to be shown as a column, but this is a good step and has a test.

@civibot
Copy link

civibot bot commented May 11, 2022

(Standard links)

@civibot civibot bot added the master label May 11, 2022
@eileenmcnaughton eileenmcnaughton merged commit 696bbcf into civicrm:master May 12, 2022
@eileenmcnaughton eileenmcnaughton deleted the groupByFn branch May 12, 2022 01:08
@petednz
Copy link

petednz commented Oct 17, 2023

Great to see this Group by (fx) available - are there major reasons why it won't offer 'week' (eg too hard to know what the starting day of the week should be?) - or could there be two options eg Week (Sun - Sat) | Week (Mon - Sun)

@petednz
Copy link

petednz commented Oct 17, 2023

also - does it make sense that if i Group By "Birth Date" i can still use Field Transformation to show the date as Month Only, but that if i do this for a Custom Date field, the transformation options are much more limited (only offering Aggregate options)

@colemanw
Copy link
Member Author

@petednz the "Partial Date" field transformation does offer "Weeks" as an option:

@petednz
Copy link

petednz commented Oct 18, 2023

Brilliant - thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants