[Import][Ref] Calculate relationship type in parser

[eileenmcnaughton]

Overview

[Import][Ref] Calculate relationship type in parser

Before

The potential values for the related contact contact type are calculated here

civicrm-core/CRM/Contact/Import/ImportJob.php

Lines 132 to 136 in c169525

	$relationType = new CRM_Contact_DAO_RelationshipType();
	$relationType->id = $id;
	$relationType->find(TRUE);
	$parserParameters['relatedContactType'][$key] = $relationType->{"contact_type_$second"};

and passed in as an array to the parser class

After

The parser class does the same calculation internally (with a little more caching)

Technical Details

Originally the parser class was given a bunch of arrays to represent the mapper saved on the form + this was munged into those - the arrays are mostly gone now but working through this & one other

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).