Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] Summary tpl - remove always-true ifs #23406

Merged
merged 1 commit into from
May 9, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] [Import] Summary tpl - remove always-true ifs

Before

There is this pattern of nesting the if clause within itself - the inner {if $invalidRowCount} must be true

image

After

poof

Technical Details

Some whitespace too

Comments

@civibot
Copy link

civibot bot commented May 9, 2022

(Standard links)

@civibot civibot bot added the master label May 9, 2022
@colemanw
Copy link
Member

colemanw commented May 9, 2022

Funny how the duplicate row clause is called $duplicateRowCount. Almost self-aware. Almost.

@colemanw colemanw merged commit 9fd3152 into civicrm:master May 9, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_no_match branch May 9, 2022 19:32
@eileenmcnaughton
Copy link
Contributor Author

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants