Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] Stop passing unused parameters #23386

Merged
merged 1 commit into from
May 6, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] [Import] Stop passing unused parameter

Before

The functions that call Import_Parser_Contact::run() are still passing parameters that it discards or does not accept

image

After

image

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 6, 2022

(Standard links)

@civibot civibot bot added the master label May 6, 2022
@eileenmcnaughton eileenmcnaughton changed the title [REF] [Import] Stop passing unused parameter [REF] [Import] Stop passing unused parameters May 6, 2022
@eileenmcnaughton
Copy link
Contributor Author

test this please

@demeritcowboy
Copy link
Contributor

This looks ok but I see a different problem. Will make a lab ticket.

@demeritcowboy demeritcowboy merged commit 1142e02 into civicrm:master May 6, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_no_var branch May 6, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants