Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing Parishes of Bermuda (civicrm_state_province) #23339

Merged
merged 2 commits into from
May 4, 2022

Conversation

ginkgomzd
Copy link
Contributor

Overview

Add missing Parishes (State/Provinces) of Bermuda.

Please help if I added the incremental to the wrong file.

References:

@civibot
Copy link

civibot bot commented May 2, 2022

(Standard links)

@civibot civibot bot added the master label May 2, 2022
@demeritcowboy
Copy link
Contributor

This looks good just for master it would go in the 5.50.alpha1.mysql.tpl file.

Also sql/civicrm_generated.mysql needs updating - you can see e.g. on the PR test site here or on a demo build with sample data that the state_provinces for Bermuda don't appear if you go to create a new contact. There's a helper script you can run online in your fork on github if you don't want to run regen locally: https://github.com/civicrm/civicrm-core/blob/master/.github/workflows/regen.yml#L1

@ginkgomzd ginkgomzd force-pushed the bermuda-parishes branch from 9cdb0d1 to 112d2e0 Compare May 4, 2022 18:32
@ginkgomzd ginkgomzd force-pushed the bermuda-parishes branch from 112d2e0 to 3797bdd Compare May 4, 2022 18:56
@ginkgomzd
Copy link
Contributor Author

okay @demeritcowboy

I moved the changes to the 5.50 incremental and ran regen.

Thanks

@demeritcowboy
Copy link
Contributor

Thanks looks good.

@eileenmcnaughton eileenmcnaughton merged commit 14146cd into civicrm:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants