Add import function to parser #23338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
This seems fine to me |
|
thanks @seamuslee001 |
eileenmcnaughton
force-pushed
the
import_preview
branch
from
1c89bb3 to
3460403
Compare
|
I slightly altered the function (but not the fact that the function is not called from anywhere as of this PR) - to add in the titles |
This function is not used in this PR but added in civicrm#23288 - however, that PR is a bit stalled & getting the function added also allows for other places to call it (ie kill off the enotices on the preview screen and remove all the silly parameters in the construct) so trying to get just the function merged
eileenmcnaughton
force-pushed
the
import_preview
branch
from
3460403 to
34f3f22
Compare
|
Fail is new to me but clearly unrelated as the function is not called CRM_Core_DAOTest::testSqlModePresent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add import function to parser to map the mapper input to it's meaning
This function is not used in as of this PR but it is used in
#23288
That PR is a bit stalled & getting the function added also allows
for other places to call it (ie kill off the enotices on the preview
screen and remove all the silly parameters in the construct)
so trying to get just the function merged