dev/core#3084 Bug fix on line item financial types

[eileenmcnaughton]

Overview

https://lab.civicrm.org/dev/core/-/issues/3084

I expect some fixes to v3 order api might be needed to get tests to pass

Before

per steps on https://lab.civicrm.org/dev/core/-/issues/3084

After

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@davejenx this should fix the regression you reported. It caused a test to fail but that test ALSO related to one of your issues - https://lab.civicrm.org/dev/core/-/issues/860 - I concluded the error was in the test & have updated the test to be more internally consistent....

[davejenx]

Fantastic, thanks @eileenmcnaughton ! This does indeed fix the regression. Apologies if one of my tests caused complications.

[demeritcowboy]

I'm confused about how much the goat costs - it looks like $15 for the goat and then $200 in taxes - I hope you at least get good road maintenance out of that. (grin)

Seriously, I don't have a good sense of how this will affect calls to Order api. But it sounds correct.

civicrm-core/CRM/Financial/BAO/Order.php

Lines 419 to 423 in e5e212b

	// We don't permit overrides if there is more than one line.
	// The reason for this constraint may be more historical since
	// the case could be made that if it is set it should be used and
	// we have built out the tax calculations a lot now.
	if (!$this->isPermitOverrideFinancialTypeForMultipleLines() && $this->getLineItemCount() > 1) {

[eileenmcnaughton]

I think it's a bit of a tax rort - you make a tax free donation AND buy a VERY CHEAP GOAT at the same time....

[demeritcowboy]

Hehe.
By the way if I search for "How much does a goat cost?", which has probably put me on all kinds of surveillance watchlists now, there's a surprising range of results, including things like a $3000 Billy Goat Debris Loader, which I both want to know more about and at the same time am scared to find out.

[eileenmcnaughton]

maaa-aaaa

[demeritcowboy]

maaa-aaaa

Agreed.