[Ref] MembershipView page - Remove redundant financialacl check

[eileenmcnaughton]

Overview

Follow on from #22664 - removes the financial acl check that @colemanw questioned removing in the PR

Before

The same should work before & after .....

1. Give webuser role 'access CiviMembership' - or merge this pr Give advisor user access to CiviMember & CiviEvent civicrm-buildkit#690 and rebuild the site...
2. In incognito login as advisor/advisor
3. Do a membership search & view a membership record
4. As admin user enable financial acls
5. try refreshing the view screen for advisor - should no longer load

After

No change in r-run, some code removed

Technical Details

#23228 needs to be merged through to master before merge (then I'll rebase it out) - but if testing / adding MOP before then you will need it :-)

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@eileenmcnaughton PR #23228 has been merged. You might want to resolve conflicts in this one. Thanks!

[eileenmcnaughton]

thanks @yashodha - done

[eileenmcnaughton]

test this please

[BettyDolfing]

Test this please

[BettyDolfing]

Test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

I just rebased this to make sure it's fresh - @yashodha or @monishdeb is one of you able to look at it?

[eileenmcnaughton]

@colemanw this is a PR I did in response to a comment from you - but it seems to have stalled (and hence I haven't been working on getting financialacls out of core for the last 6 monts) - but looking at it it seems pretty minimal & should probably be merged (the other option is to close it)

[seamuslee001]

This seems ok to me

[eileenmcnaughton]

Thanks @seamuslee001