(REF) Schema - Correct boolean fields in various tables

[monishdeb]

Overview

Followup PR #23134

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

@colemanw @demeritcowboy after reviewing each table boolean column I have prepared this patch. Can you please review this PR?

[demeritcowboy]

The test fail is because there's a single-quote missing near the end here.

[demeritcowboy]

I haven't r-run yet but I also see this, where there's conflicting defaults:

civicrm-core/xml/schema/Event/ParticipantStatusType.xml

Lines 73 to 75 in fdcb13f

	<default>1</default>
	<comment>whether this status type is active</comment>
	<default>0</default>

And then it doesn't cause a problem but both of these fields have duplicate defaults:

civicrm-core/xml/schema/Financial/PaymentProcessorType.xml

Lines 54 to 68 in fdcb13f

	<default>1</default>
	<required>true</required>
	<comment>Is this processor active?</comment>
	<add>1.8</add>
	<default>1</default>
	</field>
	<field>
	<name>is_default</name>
	<title>Processor Type is Default?</title>
	<type>boolean</type>
	<default>0</default>
	<required>true</required>
	<comment>Is this processor the default?</comment>
	<add>1.8</add>
	<default>0</default>

[demeritcowboy]

Thanks @monishdeb. I think there's still a problem somewhere - on upgrade all the civicrm_menu.is_public entries get set to 1. I'll try to debug.

And also sorry just noticing this should be against 5.49.

[demeritcowboy]

Ok this line should be removed:

civicrm-core/CRM/Upgrade/Incremental/php/FiveFortyNine/Core.bool.php

Line 62 in 379de8b

'is_public' => "DEFAULT 1 COMMENT 'Is this menu accessible to the public?'",

[eileenmcnaughton]

@monishdeb I've updated the base branch to 5.49 so we don't merge to master - obviously it has a lot to rebase out now...

[eileenmcnaughton]

@monishdeb I've put #2319 into a separate PR - as it seems to e causing much confusion - this is obviously needing rebase but we can maybe merge that first -

[monishdeb]

@eileenmcnaughton I have rebased the PR. Also, should we also remove the requiredness of menu.is_public ?

[eileenmcnaughton]

@monishdeb looks better!

I think it is correct for booleans to be required - as long as we also have a default & do the upgrade script thing

[monishdeb]

ok reverting the Menu stuff.

[monishdeb]

Done. @eileenmcnaughton can you please review the PR?

[eileenmcnaughton]

OK - I took a look at what is in this patch & all the changes make sense - I haven't verified that there is complete cover of all the changes that need to be made - only that what is in this patch looks right

[monishdeb]

Thanks @eileenmcnaughton !