Remove-single-value-loop

[eileenmcnaughton]

Overview

Remove-single-value-loop

Before

 $communicationType = [
      'address' => ['customData' => 1],
    ];
foreach ($communicationType as $key => $value) {
...

  if (isset($value['customData'])) {

After

For each loop removed

Technical Details

The communicationType array only has one value. This removes the foreach, swapping
the values for the only value they could be. This resulted in 2 always-true
ifs being replaced too

• this is follow on tidy up to a PR @demeritcowboy merged & looks worse than it is due to indentation changes

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).