Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix multi-valued afform filters #23012

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

colemanw
Copy link
Member

Overview

Fixes a SearchKit regression causing multi-select afform filters to stop working.

Before

  • Create a search for e.g. Activities
  • Add it to a Form
  • Add a multi-select filter e.g. Activity Type
  • Visit the form and try using the filter. It will return no results.

After

Fixed, test coverage added.

Technical Details

Multi-select search filters stopped working as of 007167d due to the label lookup assuming single-valued input. This fix adds a test for getting labels with multi-valued filter input.

Multi-select search filters stopped working as of 007167d
@civibot
Copy link

civibot bot commented Mar 23, 2022

(Standard links)

@seamuslee001
Copy link
Contributor

This seems fine to me merging

@seamuslee001 seamuslee001 merged commit fb919c2 into civicrm:5.48 Mar 24, 2022
@seamuslee001 seamuslee001 deleted the fixSearchAfformFilter branch March 24, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants