Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact token should show contact's info instead of logged in contact #22874

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

monishdeb
Copy link
Member

Overview

When viewing sent mailings through the contact's mailing tab, tokens should resolve to the contact you are viewing.

Before

Contact token show logged in contact

After

Contact token show contact you are viewing

Comments

ping @colemanw @lcdservices

@civibot
Copy link

civibot bot commented Mar 2, 2022

(Standard links)

@civibot civibot bot added the master label Mar 2, 2022
@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Mar 2, 2022
@demeritcowboy
Copy link
Contributor

  • General standards
    • [r-explain] PASS
    • [r-user] PASS with comment
      • This would always show the CURRENT values of the tokens, not what they were at the time it was sent.
    • [r-doc] PASS
    • [r-run] PASS
      • Unsubscribe etc links don't display correctly but that might be a good thing and is maybe already like that on purpose.
  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS
    • [r-maint] PASS
      • This might be unit-testable. Not sure offhand how hard it would be.
    • [r-test] PASS

Putting merge-ready in case anyone has any comments about whether this allows information disclosure about other contacts that it shouldn't. I don't think so since the router already supports the extra params.

@agileware-justin @stesi561 I think you've expressed an interest in this issue in the past.

@yashodha
Copy link
Contributor

yashodha commented Mar 3, 2022

@demeritcowboy looks good to merge. I am merging this.

@yashodha yashodha merged commit 83278f2 into master Mar 3, 2022
@colemanw colemanw deleted the mailing_token branch March 3, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants