dev/core#3056 - Crash with search builder if civigrant not enabled and have admin rights #22714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Nice job with the test @demeritcowboy! |
|
Test failure from first run looks related.
Cool. In this case, I think we can just edit the PR header. (The current base-commit is a common ancestor.) |
colemanw
reviewed
Feb 6, 2022
demeritcowboy
force-pushed
the
grant-searchbuilder
branch
from
f87c1bc to
8fe36e2
Compare
|
@demeritcowboy still the same test failure as before |
|
Yes but the versioncheck test that's failing is pointing to maybe a larger issue with civigrant so want to sort that out first. See https://lab.civicrm.org/dev/core/-/issues/3057. It should have been failing for the last month, and should be also failing in master. I am perplexed. |
demeritcowboy
changed the title
demeritcowboy
force-pushed
the
grant-searchbuilder
branch
from
e1f0a28 to
855e35c
Compare
|
I don't know what's different about the test node that's making it think search builder is a custom search. When I put in some debugging, on my local the "selector name" below is just CRM_Contact_Selector. What makes it be "custom" here? |
|
There is a spooky interaction between And then running the new test by itself, it passes: |
|
Specifically, the interaction arises with testOpeningForms(...Fulltext search...): |
|
I believe the leak is in protected function tearDown(): void {
parent::tearDown();
CRM_Contact_Form_Search::$_selectorName = 'CRM_Contact_Selector';
}But surely that cleanup belongs somewhere else... |
|
Ahh nice. Thanks for tracking down the spooky action. So we've invented quantum entangled tests then. Will take a look - those FormTest ones were an earlier attempt and they do have some flaws so what I might do is convert them to Invoke, but will look at the fulltext one. |
demeritcowboy
force-pushed
the
grant-searchbuilder
branch
from
7200e6d to
d2b9d0a
Compare
|
Just seeing what this breaks now. |
demeritcowboy
force-pushed
the
grant-searchbuilder
branch
from
d2b9d0a to
5dcfb8e
Compare
|
Jenkins retest this please. I've clicked around and checked universe and I think this might be the way to handle |
|
The final patch seems fine to me and I note tests have passed now. so I think this should be ok to merge right @demeritcowboy ? |
|
I added the constructor part, but otherwise it's the same as earlier. So it's just if someone sees an issue with the added constructor, which just repeats the assignment from the property declaration a few lines up. |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/3056
Search Builder, as in Search -> Search Builder (civicrm/contact/search/builder), crashes if CiviGrant not enabled and you are an admin or have access CiviGrant permission still.
Before
After
Ok
Technical Details
CiviGrant was moved to an extension in 5.47. Search builder still references it.
Comments
It looks like 5.47 hasn't branched yet so putting against master. I'll rebase if it branches first.