Set default values to avoid notices when rendering (event templates screen) #22663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Set default values to avoid notices when rendering (event templates screen)
Before
On the manage event templates screen, if an event template had participant listings disabled (i.e. no value set), then a notice would be thrown from the Smarty template.
After
No notice is thrown.
Additionally, the "Participant listing" column now contains the text "Disabled", rather than an empty cell, which matches the language used on the edit form.
Comments
Default values have also been added for
participant_role
andevent_type
. These are required fields and so should always be set, however as there areif
around where these keys are set it feels like it doesn't hurt to add the fallback values - it could catch edge-cases where event templates have been created through the API, or through poorly behaved extensions for example.