[REF] APIv4 - Rename trait 'SoftDelete' to 'SoftDeleteEntity'

[colemanw]

Overview

Simple file rename for consistency with other traits

Before

APIv4 has some "ability" traits, named:

• ManagedEntity
• SortableEntity
• ReadOnlyEntity
• SoftDelete

After

• SoftDeleteEntity

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@braders - this would be a good one for you to review

[braders]

@colemanw Honestly I'm not that familiar with the API4 code, but this looks sensible enough.

The only concern that springs to mind is that extensions could be using this trait - you'll know better than me if that's a legitimate concern or not.

[colemanw]

In general that's a smart thing to consider @braders. In this particular case I would say very unlikely because the trait is new, internal, and not documented anywhere. However I vaguely recall @monishdeb working on some extension code where I suggested this trait might be useful to him, so I'll just add merge-ready here and give him a chance to double-check that.

[demeritcowboy]

Github still thinks jenkins is queued for this but it appears to have passed tests and is pretty straightforward.