Fix smarty notices in membership dashboard #22660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix smarty notices in membership dashboard.
Before
On visiting the membership dashboard, many PHP notices were logged. (as shown in a WordPress environment running query monitor):
After
The notices have gone (most of them anyway!)
Comments
If the GET query param
date
is used to show a specific period, then there a couple of remaining notices related tourl
that I could not track down. However, I suspect thedate
GET param is largely unknown, so I didn't spend too much time looking into this.