Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smarty notices in membership dashboard #22660

Merged

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 29, 2022

Overview

Fix smarty notices in membership dashboard.

Before

On visiting the membership dashboard, many PHP notices were logged. (as shown in a WordPress environment running query monitor):

Screenshot 2022-01-29 at 12 13 06

After

The notices have gone (most of them anyway!)

Screenshot 2022-01-29 at 12 12 38

Comments

If the GET query param date is used to show a specific period, then there a couple of remaining notices related to url that I could not track down. However, I suspect the date GET param is largely unknown, so I didn't spend too much time looking into this.

@civibot
Copy link

civibot bot commented Jan 29, 2022

(Standard links)

@civibot civibot bot added the master label Jan 29, 2022
@colemanw
Copy link
Member

@braders some style issues got flagged

@braders braders force-pushed the membership-dashboard-smarty-notices branch from 3e4e9b7 to 54c7d24 Compare January 29, 2022 15:45
@braders
Copy link
Contributor Author

braders commented Jan 29, 2022

@braders some style issues got flagged

Resolved. One day I might remember Civi likes uppercase booleans!

@colemanw
Copy link
Member

Looks good, thanks!

@colemanw colemanw merged commit 5e230e6 into civicrm:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants