Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add civicrm_admin_ui extension #22628

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 26, 2022

Overview

Adds a new bundled extension. So far this extension replaces 2 screens with SearchDisplay Afforms:

  • Custom field groups
  • Custom fields

Before

Old screens made with Smarty

After

New screens look very similar, but made with SearchKit and thus user-configurable:

image

@civibot civibot bot added the master label Jan 26, 2022
@civibot
Copy link

civibot bot commented Jan 26, 2022

(Standard links)

@colemanw colemanw force-pushed the civicrm_admin_ui branch 3 times, most recently from 434b4e0 to 9f45c30 Compare January 26, 2022 21:17
@mattwire
Copy link
Contributor

@colemanw Looks very nice but can we keep the group/field IDs in by default? That was a feature added a few years ago that a lot of people find very useful.
image

On second thoughts the ID will become less useful now we can use API4 and access them via the Group_name.field_name syntax instead.. is it currently possible to expose that style as one of the fields? Does not need to be by default but should be possible as it saves so much time when doing any extension/custom work. I just had to talk someone (non-dev) through getting the API4 custom field name through the API4 explorer and they really struggled.

@kcristiano
Copy link
Member

@mattwire I do think we should keep the IDs exposed. These have proven useful in many case for us and our Clients CiviCRM admins.

@colemanw
Copy link
Member Author

Ok added ID column

@monishdeb
Copy link
Member

Jenkins test this please

@monishdeb
Copy link
Member

@colemanw I found two issues:

  1. On previewing the custom field, it get a blank popup screen
  2. Done button background is white, which makes it difficult to read on hover.

Here's a screencast to demonstrate the two issues:

before

Used test build site http://core-22628-6cyb1.test-3.civicrm.org:8001 ( admin / 2bCuOWlAzpMB )

@colemanw
Copy link
Member Author

colemanw commented Feb 1, 2022

@monishdeb thanks for the review. I've fixed the preview link. I think the button styling is a generic theme issue which we should address separately.

@colemanw colemanw marked this pull request as draft February 1, 2022 19:40
@colemanw
Copy link
Member Author

colemanw commented Feb 1, 2022

I'm marking this as a draft because there's one outstanding bug: the drag-sorting is not working properly.

@demeritcowboy
Copy link
Contributor

I did a little testing of this along with #22716. Because drag'n'drop is frustrating over long lists and the old "move to top/bottom" buttons were handy, I altered the search display to include Order and made it edit-in-place. That works as a workaround (with 22716 applied).

I agree the Done button is weird. Does something like the custom fields page even need a Done button?

So far this extension replaces 2 screns with SearchDisplay Afforms:
- Custom field groups
- Custom fields
@colemanw colemanw marked this pull request as ready for review February 7, 2022 21:09
@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Feb 7, 2022
@colemanw
Copy link
Member Author

colemanw commented Feb 7, 2022

Ok I think all the major issues have been addressed so I'm giving this merge-ready.
Note that merging this PR simply adds a new extension which is deactivated by default.

@eileenmcnaughton
Copy link
Contributor

I'm merging this since it is de-activated default & known concerns are addressed

@eileenmcnaughton eileenmcnaughton merged commit 5c81ef7 into civicrm:master Feb 8, 2022
@eileenmcnaughton eileenmcnaughton deleted the civicrm_admin_ui branch February 8, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants