-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add civicrm_admin_ui extension #22628
Conversation
(Standard links)
|
434b4e0
to
9f45c30
Compare
@colemanw Looks very nice but can we keep the group/field IDs in by default? That was a feature added a few years ago that a lot of people find very useful. On second thoughts the ID will become less useful now we can use API4 and access them via the |
@mattwire I do think we should keep the IDs exposed. These have proven useful in many case for us and our Clients CiviCRM admins. |
9f45c30
to
4028df1
Compare
Ok added ID column |
Jenkins test this please |
@colemanw I found two issues:
Here's a screencast to demonstrate the two issues: Used test build site http://core-22628-6cyb1.test-3.civicrm.org:8001 ( admin / 2bCuOWlAzpMB ) |
@monishdeb thanks for the review. I've fixed the preview link. I think the button styling is a generic theme issue which we should address separately. |
I'm marking this as a draft because there's one outstanding bug: the drag-sorting is not working properly. |
I did a little testing of this along with #22716. Because drag'n'drop is frustrating over long lists and the old "move to top/bottom" buttons were handy, I altered the search display to include Order and made it edit-in-place. That works as a workaround (with 22716 applied). I agree the Done button is weird. Does something like the custom fields page even need a Done button? |
So far this extension replaces 2 screns with SearchDisplay Afforms: - Custom field groups - Custom fields
8c65fad
to
5aa8430
Compare
Ok I think all the major issues have been addressed so I'm giving this |
I'm merging this since it is de-activated default & known concerns are addressed |
Overview
Adds a new bundled extension. So far this extension replaces 2 screens with SearchDisplay Afforms:
Before
Old screens made with Smarty
After
New screens look very similar, but made with SearchKit and thus user-configurable: