ExtensionUpgrades - Skip trying to upgrade missing dependencies

[colemanw]

Overview

This allows the extension upgrade to proceed without error, even if there are missing dependencies.
The user will be prompted to install the missing dependencies afterward, e.g. #22464

See https://lab.civicrm.org/dev/core/-/issues/3036

Before

All dependencies would be added to the upgrade queue and then the extension upgrader would try and fail to upgrade them even if they were missing.

After

Upgrading dependencies is skipped.

Technical Details

Maybe I'm missing something, but that while loop with the tracking variables and the array_shift() seemed overcomplicated. I had to read it a couple times to figure out that all it does is iterate through each item once. That can be more simply achieved with a foreach loop, so I changed it to that.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks @colemanw will take a look.

[demeritcowboy]

I think this should be against 5.46 but otherwise this works well for me. After upgrade you get presented with two options and it's not clear which to do first, but the top one says "as soon as possible". Even if you do visit the extensions page first what happens is you get a popup alert about needing to run upgrades. So I think the average admin would run upgrades first, but it does still all work if you install search kit first too.

[colemanw]

Sounds like we could merge this and work out the messaging in a followup PR.

[colemanw]

I'd like @totten to weight in since this is his code I'm mangling, just to double-check that I'm not removing something important.

[colemanw]

Retest this please

[totten]

In the screenshot that @demeritcowboy showed above, it includes the status warning about "Extension Error": "Form Builder depends on org.civicrm.search_kit, which is not enabled."

Two things:

• This message doesn't in 5.46. One needs to backport Extensions - Add dependency status check #22464 to 5.46.
• The message prose feels a little strange (one extension by name; the other by key?). I'd go for something like this pseudocode:

  "$dependentName" (<code>$dependentKey</code>) depends on missing extension "$dependencyName" (<code>$dependencyKey</code>). 
  Please <a href="civicrm/admin/extensions?reset=1">correct the extension configuration</a>.

I'd say those can fixed in 5.46/5.45 in the scope of dev/core#1306, but they don't have to be in this PR.

[colemanw]

@totten I changed that comment to a throw new CRM_Extension_Exception('Invalid extension key... because I think it's so unlikely to happen we really ought to know about it if it does.

[totten]

I'll give one last bit of r-run with and then merge.