SearchKit - Allow smarty in field rewrite #22592
Conversation
|
(Standard links)
|
| civicrm_api4('SearchDisplay', 'run', $params); | ||
| $this->fail(); | ||
| } | ||
| catch (\Exception $e) { |
There was a problem hiding this comment.
What exception does it catch here?
There was a problem hiding this comment.
I don't really understand the mechanics of it, but smarty calls trigger_error and somehow that's catchable in the unit test, but I wasn't able to do much with it. $e->getMessage() returns an empty string.
There was a problem hiding this comment.
Oh right THAT error - yeah it is inconsistently escalated - there has been discussion before about consistently escalating to being a 'real live error' - it kinda got too hard to do it for the code we currently use because it skipped the scope of the deprecated classes - but I think it would be worth wrapping & escalating your fetch with an error handler like
so that we don't create a new place that behaves inconsistently across the different CMS
There was a problem hiding this comment.
note I think the handler would go on CRM_Core_Smarty
There was a problem hiding this comment.
@eileenmcnaughton is that a blocker on this PR?
Overview
This gives the ability to use Smarty syntax in the "rewrite" of SearchKit displays.
Before
Tokens like
[first_name]supported.After
Those tokens still work and will be evaluated first. They can be mixed in with Smarty tags like
{if "[first_name]"}.Technical Details
Smarty will see the evaluated values for the tokens (which should be quoted if string and inside a smarty tag).
Note: Due to #1371, PHP filters like
strtolowerorucfirstcannot be used.Comments
This is #22346 without assigning the variables, which @eileenmcnaughton recommended against.