Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistency between checkTemplateFileExists functions, #22586

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 20, 2022

Overview

Add consistency between checkTemplateFileExists functions, resolving phpdoc issues in the process.

Before

Each checkTemplateFileExists method in core is fundamentally performing the same job (on different components). Therefore it makes sense for the method comment to match.

In doing so, these methods have a consistent signature, accepting either string|null for $suffix.

The primary benefit of this is that the method in CRM/Profile/Form.php is now correctly documented as accepting a string for $suffix.

After

Consistency added.

resolving phpdoc issues in the process.
@civibot
Copy link

civibot bot commented Jan 20, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Thanks @braders - another improvement!

@eileenmcnaughton
Copy link
Contributor

This should fix those errors - although I don't know why they popped up #22590

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton merged commit 4ed0d7f into civicrm:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants