Remove method getWordReplacement. #22577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove method
getWordReplacement
.It appears to have never been used since its introduction 8 years ago,
and furthermore calls functions which don't exist.
Therefore, it would be unlikely to work even if it were used.
Before
Function
CRM_Core_BAO_WordReplacement::getWordReplacement()
exists. I highly expect it does not work, and would not work even if sometried to use it. Specifically, the methodCRM_Core_Config::wordReplacementID()
, which the removed method calls, does not appear to exist.After
Method removed.
Technical Details
The method was introduced here: d83a399
A search with
git log -S "getWordReplacement("
shows no other references to this method since.Comments
There may be an argument for deprecating, but the unlikelyhood of this method actually working makes me think its probably safe to just remove.