Remove category from case activity template

[eileenmcnaughton]

Overview

Remove category from case activity template

Before

The empty checks for `$activity['fields']['category'] cause enotices when smarty is in strict mode

After

I removed references to the parameters

Technical Details

@demeritcowboy I originally thought to ensure this was assigned - but I can't find anywhere where it is set outside the Audit report code CRM_Case_Audit_Audit that seems to use a different template so am suggesting just removing from the template. Note that I will regenerate the sql (before or after this is merged) if agreed but I won't do any upgrade changes as it's not going to matter for existing sites if it already is always empty & they are unlikely to see the notice anyway so we can wait for a more material change

Comments

This is not the only potential variable issue in this tpl -but there is enough complexity in confirming this change I kept it alone

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I'm not at a computer right now but maybe for the compucorp extension which has something about categories?

I can't imagine message templates being related to the 'audit' code.

[eileenmcnaughton]

@demeritcowboy if it DOES relate to the compucorp extension then I think it's fine to remove from the core default message template - there is a small chance the extension or some people might edit it back in & I'm not proposing to auto-remove from existing installs (or even notify people to consider manual updating at this stage)

[demeritcowboy]

I don't really remember this, but am pretty convinced now it was from an early version of the xml spec. And this ticket sort of supports that: https://issues.civicrm.org/jira/browse/CRM-3847

i.e. you used to be able to specify a category for each activity type in the xml.

[eileenmcnaughton]

thanks @demeritcowboy - I'll regenerate...