Test cleanup - remove direct calls to BAO_Membership::add

[eileenmcnaughton]

Overview

Test cleanup - remove direct calls to BAO_Membership::add

Before

Direct BAO add called

After

API v4 used

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Is the idea to deprecate BAO::add()? Because these tests are in a file called BAO, and most of the changes remove coverage of the BAO and are now covering API4.

Otherwise this seems ok.

[eileenmcnaughton]

@demeritcowboy yeah - I think in general we want to stop calling BAO crud functions directly - even in tests

It does creat a file structure challenge - which is already doing my head in - ie do we test crud from apiv3 files , v4 files or BAO files - esp when testing both api versions

I kinda feel like we should move apiv3 crud to somewhere else because one day v3 api will die out - but the tests will still matter

@colemanw

[colemanw]

I think it's ok for the tests to be updated to use the API.
I'm less clear about internal code; I think some code like a form pre/postprocess make sense to use the API, but very low-level stuff seems a little more dicey. But that's a different discussion.