Fully remove contactAB function #22485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was a really long winded way of doing what the 3 lines do. Universe search did not reveal other usages and it is not the sort of function we would expect to be used by extensions so I'm straight removing it
|
(Standard links)
|
| @@ -170,7 +170,8 @@ public static function legacyCreateMultiple($params, $ids = []) { | |||
| // only returns 2 calls - one in CRM_Contact_Import_Parser_Contact | |||
| // and the other in jma grant applications (CRM_Grant_Form_Grant_Confirm) | |||
| // both only pass in contact as a key here. | |||
| $ids = ['contact' => $ids['contact']]; | |||
| $contactID = $ids['contact']; | |||
| unset($ids); | |||
There was a problem hiding this comment.
just for clarity...
| $returnFields = []; | ||
|
|
||
| // $ids['contact'] is deprecated but comes from legacyCreateMultiple function. | ||
| if (empty($ids['contact'])) { |
There was a problem hiding this comment.
ignore this if - never true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fully remove contactAB function
Before
The function was a really long winded way of doing what the 3 lines do.
Universe search did not reveal other usages and it is not the
sort of function we would expect to be used by extensions so
I'm straight removing it
After
poof
Technical Details
Comments