Move function to the class that 'owns' it #22472

eileenmcnaughton · 2022-01-11T11:52:37Z

Overview

Move function to the class that 'owns' it

Following f54e87d#diff-5864d6a1d03dffb7699b930837c1c222b41fba16dad7d0a5f73b4923ac53dd42R198
neither of these functions are called from outside their class (I did a universe search)
so making them private (& in one case moving off the parent) means a universe seach won't be needed
next time

private & protected

civibot · 2022-01-11T11:52:39Z

(Standard links)

If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

Following civicrm@f54e87d#diff-5864d6a1d03dffb7699b930837c1c222b41fba16dad7d0a5f73b4923ac53dd42R198 neither of these functions are called from outside their class (I did a universe search) so making them private (& in one case moving off the parent) means a universe seach won't be needed next time

civibot bot added the master label Jan 11, 2022

eileenmcnaughton force-pushed the import branch from 99ae12d to 2f8de76 Compare January 11, 2022 11:57

eileenmcnaughton force-pushed the import branch from 2f8de76 to 5484728 Compare January 11, 2022 18:45

demeritcowboy merged commit ab76f7e into civicrm:master Jan 12, 2022

eileenmcnaughton deleted the import branch January 12, 2022 00:38