Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enotice fixes #22471

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Enotice fixes #22471

merged 1 commit into from
Jan 14, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

I grepped for 'editor' being assigned & didn't find it. I think changed the editor to 'TextArea'
and didn't see the text inside the if so I concluded it is broken. Removing rather than
fixing cos no-one noticed it was broken so can't have been important (and probably the
wrong place for it)

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

I grepped for 'editor' being assigned & didn't find it. I think changed the editor to 'TextArea'
and didn't see the text inside the if so I concluded it is broken. Removing rather than
fixing cos no-one noticed it was broken so can't have been important (and probably the
wrong place for it)
@civibot
Copy link

civibot bot commented Jan 11, 2022

(Standard links)

@civibot civibot bot added the master label Jan 11, 2022
@demeritcowboy demeritcowboy merged commit 77b5020 into civicrm:master Jan 14, 2022
@demeritcowboy
Copy link
Contributor

demeritcowboy commented Jan 14, 2022

5d51a2f#diff-b49ba142d264612517ea640be98eab6b82c8083c557bff6973890499d04e778fL1383

And some bonus code to ponder:

    $includeWysiwygEditor = FALSE;
    $includeWysiwygEditor = $this->get('includeWysiwygEditor');
    if (!$includeWysiwygEditor) {
      $includeWysiwygEditor = TRUE;

@eileenmcnaughton eileenmcnaughton deleted the noticesm branch January 15, 2022 18:53
@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy erm.....that is crazy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants