fixes report#93: SearchKit shows broken external URLs #22437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SearchKit no longer links correctly to external URLs. This is a regression introduced by #21820 in Civi 5.44. Detailed replication steps here: https://lab.civicrm.org/dev/report/-/issues/93
Before
External URLs are prefixed with the internal URL.
After
External URLs are rendered correctly.
Technical Details
I think this is just a truthiness issue -
strpos
returns0
if the needle is found at the first position in the haystack.