Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes report#93: SearchKit shows broken external URLs #22437

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

MegaphoneJon
Copy link
Contributor

Overview

SearchKit no longer links correctly to external URLs. This is a regression introduced by #21820 in Civi 5.44. Detailed replication steps here: https://lab.civicrm.org/dev/report/-/issues/93

Before

External URLs are prefixed with the internal URL.

After

External URLs are rendered correctly.

Technical Details

I think this is just a truthiness issue - strpos returns 0 if the needle is found at the first position in the haystack.

@civibot
Copy link

civibot bot commented Jan 9, 2022

(Standard links)

@civibot civibot bot added the master label Jan 9, 2022
@seamuslee001
Copy link
Contributor

this seems fine to me @colemanw

@seamuslee001 seamuslee001 changed the base branch from master to 5.46 January 9, 2022 23:04
@civibot civibot bot added 5.46 and removed master labels Jan 9, 2022
@eileenmcnaughton
Copy link
Contributor

thanks @MegaphoneJon - does this need backporting to 5.45?

@MegaphoneJon
Copy link
Contributor Author

thanks @MegaphoneJon - does this need backporting to 5.45?

I would say yes.

@MegaphoneJon MegaphoneJon deleted the broken-search-urls branch January 12, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants