Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Rename variable to be meaningful #22431

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 9, 2022

It turns out key is organizationID - rename ... on the original relationship BAO if is relatedContactID as it may not be an organization

@civibot civibot bot added the master label Jan 9, 2022
@civibot
Copy link

civibot bot commented Jan 9, 2022

(Standard links)

It turns out key is organizationID - rename ...

I did this in both places the function is called from - as I clean up the copy some
cleanups on the original emerge too
@colemanw
Copy link
Member

colemanw commented Jan 9, 2022

I confirm that $value is never used.

@colemanw
Copy link
Member

colemanw commented Jan 9, 2022

retest this please

@seamuslee001 seamuslee001 merged commit 3d94ba2 into civicrm:master Jan 9, 2022
@seamuslee001 seamuslee001 deleted the leg branch January 9, 2022 23:06
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants