Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove htmlFile validation rule, as it can't possibly work. #22425

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 8, 2022

Overview

Remove htmlFile validation rule, as it can't possibly work.

Before

CRM_Utils_Rule::htmlFile is trying to call CRM_Utils_File::isHtmlFile which doesn't exist (and I can't find any history of it ever existing, although it might have in the SVN days). Therefore, I can't see how this function can possibly work, it makes sense to remove it.

After

htmlFile rule gone.

as it can't possibly work.
@civibot
Copy link

civibot bot commented Jan 8, 2022

(Standard links)

@civibot civibot bot added the master label Jan 8, 2022
@demeritcowboy demeritcowboy merged commit 8104b62 into civicrm:master Jan 8, 2022
@demeritcowboy
Copy link
Contributor

I think it was a typo and meant to be CRM_Utils_File::isHtml(), but regardless I agree it's unused.

And then it looks like maybe so is CRM_Utils_File::isHtml().

And also CRM_Utils_Rule::asciiFile().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants